Review 14.3 Merged

96989[BUGFIX] Stop probing settings once the tree is empty

Oli Bartsch CR +2 V +2 Normal +167 −0 updated 10/22/26, 08:07

Commit message

SettingsFactory passes the definitions of all previously resolved
sets to every settings provider. Most sets have no settings.yaml,
so their SiteSettingsProvider holds an empty settings tree, yet
SiteSettingsProvider::getProvidedSettings() still checked every
accumulated definition key against it. The effort grows
quadratically with the number of sets and adds seconds to a
request with a cold cache when many sites and sets are involved.

The loop now stops as soon as the tree is empty. The result is
unchanged.

In a test with 200 sites, the time spent in this method dropped
from 1.4 s to 50 ms for map notation and 280 ms for tree notation.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 34

  1. Oli Bartsch commented on patch set 1 10/22/26, 07:48

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/22/26, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112070

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 10/22/26, 08:07

  4. Oli Bartsch merged patch set 2 10/22/26, 08:07