Review 14.3 Merged

97014[BUGFIX] Handle null bytes in Extbase DateTimeConverter

Benni Mack CR +2 V +2 Normal +55 −10 updated 10/22/26, 16:09

Commit message

Since PHP 8.0, DateTime::createFromFormat() and the DateTimeZone
constructor throw a ValueError if the given string contains a null
byte. As request arguments may contain such bytes (e.g. "%00"), a
manipulated form submission led to an uncaught error.

The DateTimeConverter now returns the regular validation error for
date strings containing null bytes and throws the existing
TypeConverterException for such timezones.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benni Mack commented on patch set 1 10/22/26, 15:52

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/22/26, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112140

  3. Benni Mack voted on patch set 1 CR +2 V +2 10/22/26, 16:09

  4. Benni Mack merged patch set 2 10/22/26, 16:09