Review 14.3 Merged

97020[BUGFIX] Detect capslock independent of shift key

Oli Bartsch CR +2 V +2 Hard +216 −139 updated 10/22/26, 18:40

Commit message

The capslock warning of the backend login guessed the capslock state
from the case of the typed character and the shift key. On macOS
capslock combined with shift still produces upper case characters, so
the warning disappeared, and non-letter keys removed it as well.

The state is now read with KeyboardEvent.getModifierState() on keydown
and keyup, which also reacts to toggling capslock itself. The handling
is moved into its own module, which is loaded by the password reset
form as well, whose fields now use an input group to show the warning.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 8

Review log 34

  1. Oli Bartsch commented on patch set 1 10/22/26, 16:35

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/22/26, 16:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112153

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 10/22/26, 18:40

  4. Oli Bartsch merged patch set 2 10/22/26, 18:40