Review 14.3 Merged

97041[TASK] Await clicks in Playwright fixtures

Georg Ringer CR +2 V +2 Easy +4 −4 updated 10/23/26, 05:58

Commit message

The module and FormEngine fixtures, as well as the recycler spec,
installed a waiter for the next module load and then triggered the
click without awaiting it. A failing click therefore surfaced as an
unhandled rejection or as a timeout of the waiter, instead of the
actual error of the click.

The clicks are awaited now. The waiter is installed before the click
as before, so no load event can be missed.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 34

  1. Georg Ringer commented on patch set 1 10/23/26, 05:33

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/23/26, 05:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112210

  3. Georg Ringer voted on patch set 1 CR +2 V +2 10/23/26, 05:58

  4. Georg Ringer merged patch set 2 10/23/26, 05:58