Review 14.3 Merged

97063[BUGFIX] Keep records with invisible relations in Extbase queries

Benni Mack CR +2 V +2 Hard +267 −16 updated 10/23/26, 15:24

Commit message

If a query references a property of a relation, e.g. a constraint
on "posts.title" or an ordering by "author.name", Extbase joins the
related table. The visibility constraints of that table were added
to the WHERE clause as "(visible OR uid IS NULL)".

A deleted or hidden related record is still joined, though, and its
row does not fulfill this condition. A record which only has such
relations was removed from the result, even if it matched another
part of an OR constraint or if the relation was only used for the
ordering.

The visibility constraints of joined tables are now part of the join
condition. Invisible related records are not joined anymore and can
still not match a constraint, while the record itself is kept.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 57

  1. Benni Mack commented on patch set 1 10/23/26, 09:15

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/23/26, 09:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112254

  3. Benni Mack commented on patch set 2 V -1 10/23/26, 14:08

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 10/23/26, 14:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112316

  5. Oliver Klee voted on patch set 2 V +1 10/23/26, 14:33

  6. Benni Mack voted on patch set 2 CR +2 V +2 10/23/26, 15:24

  7. Benni Mack merged patch set 3 10/23/26, 15:24