Review 14.3 Merged

97079[TASK] Enable ESLint no-unnecessary-type-assertion

Benjamin Kott CR +2 V +2 Normal +100 −100 updated 10/23/26, 13:58

Commit message

The rule `@typescript-eslint/no-unnecessary-type-assertion` reports
type assertions that do not change the type of an expression. They are
removed, so the code is checked against the inferred type. Where an
assertion was the only context a DOM query inferred its element type
from, a type argument takes its place, as introduced with #105417.

Without strictNullChecks the rule also reports every non-null
assertion, so these are removed as well until strictNullChecks is
enabled. The generated JavaScript does not change.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
  • Verified V +2 Done
    • Benjamin Kott +2
    • core-ci +1 CI

Issues 3

Files 49

Show 29 more files

Review log 58

  1. Benjamin Kott commented on patch set 1 10/23/26, 13:22

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/Sources/TypeScript/backend/form-engine.ts * Build/Sources/TypeScript/backend/form-engine/element/extra/item-count.ts * Build/Sources/TypeScript/reactions/tests/field-map-element-test.ts * Build/Sources/TypeScript/rte-ckeditor/plugin/typo3-link.ts
  2. Benjamin Kott uploaded patch set 2 10/23/26, 13:29

  3. Benjamin Kott commented on patch set 2 10/23/26, 13:34

    This change is ready for review.
  4. core-ci voted on patch set 1 V -1 10/23/26, 13:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112308

  5. core-ci voted on patch set 2 V -1 10/23/26, 13:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112310

  6. core-ci voted on patch set 2 V +1 10/23/26, 13:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112310

  7. Benjamin Kott voted on patch set 2 CR +2 V +2 10/23/26, 13:58

  8. Benjamin Kott merged patch set 3 10/23/26, 13:58