Review 14.3 Merged

97086[BUGFIX] Discard invalid mount point pairs in frontend requests

Benni Mack CR +2 V +2 Easy +32 −2 updated 10/25/26, 17:33

Commit message

The MP parameter is excluded from the cHash calculation, so any
request can pass it. PageInformationFactory only removed characters
other than digits, comma and dash, which turned e.g. "MP=<sz2B"
into "2". This value ended up in generated links, and PageRouter
emitted "Undefined array key 1" warnings for each link while
splitting the pair, causing an exception in development context.

Invalid pairs are now discarded the same way as already done by
RootlineUtility::sanitizeMountPointParameter(), so only pairs
in the format "123-456" are kept.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 58

  1. Benni Mack commented on patch set 1 10/23/26, 15:14

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/23/26, 15:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112341

  3. Benni Mack rebased onto patch set 2 V -1 10/23/26, 21:26

  4. core-ci voted on patch set 2 V -1 10/23/26, 21:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112365

  5. Benni Mack commented on patch set 3 V -1 10/25/26, 17:10

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V +1 10/25/26, 17:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112526

  7. Benni Mack voted on patch set 3 CR +2 V +2 10/25/26, 17:33

  8. Benni Mack merged patch set 4 10/25/26, 17:33