Review 14.3 Merged

97181[BUGFIX] Encode TOTP issuer consistently in otpauth URI

Oli Bartsch CR +2 V +2 Easy +11 −1 updated 10/27/26, 22:32

Commit message

Totp::getTotpAuthUrl() applied htmlspecialchars() to the issuer before
http_build_query() percent-encoded it for the "issuer" query parameter,
while the label prefix only used rawurlencode(). If the sitename
contained &, <, >, " or ', the "issuer" parameter therefore carried an
HTML entity such as "&amp;" and no longer matched the label prefix, as
required by the Key Uri Format.

The HTML escaping is dropped. The URI is fully percent-encoded, and the
value is escaped by Fluid where it is rendered in the setup view.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oli Bartsch commented on patch set 1 10/27/26, 21:53

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/27/26, 22:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112666

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 10/27/26, 22:32

  4. Oli Bartsch merged patch set 2 10/27/26, 22:32