Review 14.3 Merged

97185[TASK] Declare CRLF constant for PHPStan

Benni Mack CR +2 V +2 Easy +1 −0 updated 10/28/26, 08:36

Commit message

PHPStan 2.3.3 no longer discovers the CRLF constant from its
conditional define() in SystemEnvironmentBuilder, which breaks
the nightly composerInstallMax builds with 328 constant.notFound
errors.

Declare CRLF in the PHPStan bootstrap file next to LF and CR.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 34

  1. Benni Mack commented on patch set 1 10/28/26, 08:02

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/28/26, 08:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112684

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 10/28/26, 08:36

  4. Oli Bartsch merged patch set 2 10/28/26, 08:36