Review 14.3 Merged

97193[BUGFIX] Render multiple file uploads in form email finishers

Oli Bartsch CR +2 V +2 Normal +66 −8 updated 10/28/26, 13:36

Commit message

A FileUpload or ImageUpload element with "multiple" enabled holds an
ObjectStorage. RenderFormValueViewHelper flags such a value as multi
value, but FileUpload::processElementValue() imploded the file names
into a single string. The email finisher templates iterate the
processed value of multi value elements, so the submission ended in
an InvalidArgumentValueException of the ForViewHelper and no mail was
sent.

The processed value of a multiple upload is now a list of file names,
matching what FormValueResolver returns for an ObjectStorage. A single
upload still resolves to its file name.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Oli Bartsch commented on patch set 1 10/28/26, 13:04

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 10/28/26, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112708

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 10/28/26, 13:36

  4. Oli Bartsch merged patch set 2 10/28/26, 13:36