Review 14.3 Merged

97205[BUGFIX] Skip subpage check for language menu items

Oli Bartsch CR +2 V +2 Easy +16 −3 updated 10/28/26, 20:54

Commit message

Since AbstractMenuContentObject::getMenuItems() is used by the
LanguageMenuProcessor, hasSubpages is calculated for every language
menu item by calling isSubMenu(). All of these items represent the
current page, so each call loads every subpage of the current page
with all columns. On pages with a very large number of subpages this
exhausts the available memory.

Language menus never evaluated this state before, because their items
carry an explicit ITEM_STATE. getMenuItems() therefore no longer calls
isSubMenu() for items of a language menu and omits the hasSubpages
key for them, as language menus did before TYPO3 v14.1.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 35

  1. Oli Bartsch commented on patch set 1 10/28/26, 18:26

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/28/26, 19:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112748

  3. core-ci voted on patch set 1 V +1 10/28/26, 20:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112748

  4. Oli Bartsch voted on patch set 1 CR +2 V +2 10/28/26, 20:54

  5. Oli Bartsch merged patch set 2 10/28/26, 20:54