97241[BUGFIX] Filter Extbase queries by current workspace
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/41/97241/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/41/97241/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Oliver Klee +1
- Alexander Schnitzler +1
-
Verified V +1 Needs a vote
- Oliver Klee +1
- Alexander Schnitzler +1
- core-ci +1 CI
Merge conflicts 7
- main 97535[!!!][FEATURE] Introduce site language option "languageMode"
- main 97455[!!!][FEATURE] Introduce language fallback type "connected"
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 95162[BUGFIX] Handle empty dates consistently in Extbase
- main 96533[WIP][!!!][TASK] Build Extbase persistence on doctrine/orm
- main 88948[!!!][TASK] Refactor Property Handling in AbstractDomainObject
- main 92589[TASK] Replace unneeded instanceof on xxx|null. Use a null check instead
Issues 1
Files 3
Review log 1417
-
Garvin Hicking uploaded patch set 1 10/30/26, 15:04
-
core-ci voted on patch set 1 V +1 10/30/26, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112888
-
Oliver Klee commented on patch set 1 V +1 10/30/26, 16:05
-
Garvin Hicking commented on patch set 1 10/30/26, 16:08
WorkspaceTest.php:58ReplyYes, you're right, I'll need to remove this. I targeted the execution wrongly to one test method and it didn't perform it outside properly, thanks for pointing it out! -
Garvin Hicking commented on patch set 2
V +110/30/26, 20:15Published edit on patch set 1. -
Garvin Hicking commented on patch set 2 10/30/26, 20:16
WorkspaceTest.php:58ReplyDone -
core-ci voted on patch set 2 V +1 10/30/26, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112906
-
Benni Mack voted on patch set 2 CR +1 V +1 10/30/26, 20:48
-
Oli Bartsch commented on patch set 2 V -1 10/30/26, 21:36
Unresolved
Let me check please -
Oli Bartsch commented on patch set 2 10/30/26, 21:47
Typo3DbQueryParser.php:318UnresolvedThe two subselect builders have the same gap. Suggest to either add the restriction there as well or open a follow-up issue.Typo3DbQueryParser.php:651The `t3ver_wsid` filter only covers the root alias. With `OVERLAYS_MIXED` (the default `fallback` language type), the translated-only subselect doesn't check `t3ver_wsid`, so a translation created new in a workspace still hides its live default record. Meanwhile the draft translation itself is now filtered out, so neither record shows in live. Joined property paths like `posts.title` can still match draft rows too. Please add `WorkspaceRestriction` for the current workspace in `initializeQueryBuilder()`, since `leftJoin()` puts it into the ON clause and covers all joins. Add the same restriction to both language subselect builders, because they are built separately and never inherit it. Please keep `t3ver_oid = 0` at the root, as the restriction lets move pointers through.WorkspaceTest.php:304UnresolvedThis only checks the draft title... Can we add `self::assertSame(count($titles), $query->count())` + a case with `LanguageAspect(1, 1, OVERLAYS_MIXED)` (live default record plus a translation new in workspace 1, expecting the default in live), and finally a `equals('posts.title', ...)` constraint on a post new in another workspace (expecting no match)? -
Benni Mack commented on patch set 2 CR 0 V 0 10/30/26, 22:00
Typo3DbQueryParser.php:651Reply Unresolvedgood catch! -
Oli Bartsch uploaded patch set 3
V +111/03/26, 09:48 -
core-ci voted on patch set 3 V +1 11/03/26, 09:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113136
-
Garvin Hicking commented on patch set 3 11/03/26, 10:26
thanks Oli; lgtm -
Oliver Klee voted on patch set 3 V +1 11/03/26, 11:13
-
Alexander Schnitzler voted on patch set 3 CR +1 V +1 11/11/26, 11:10
-
Oliver Klee voted on patch set 3 CR +1 11/11/26, 11:55
WorkspaceTest.php:58