Review 14.3 Ready for review Quiet

97243[BUGFIX] Filter Extbase queries by current workspace

Garvin Hicking CR 0 V 0 Normal +51 −2 updated 10/30/26, 21:42

Commit message

Records created in a workspace have `t3ver_oid = 0`, so the filter on
`t3ver_oid` alone does not exclude them.

In backend context, and in frontend context with ignored enable fields,
nothing else checks `t3ver_wsid`. Extbase repositories therefore
returned unpublished records in the live workspace and in other
workspaces, while `count()` already applied the WorkspaceRestriction
and disagreed with `execute()`.

The constraint now also limits `t3ver_wsid` to live and the current
workspace, as `WorkspaceRestriction` does.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/43/97243/2 && git checkout FETCH_HEAD
Cherry-pick onto 14.3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/43/97243/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 3

Review log 24

  1. Garvin Hicking commented on patch set 1 10/30/26, 21:13

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 10/30/26, 21:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112909

  3. Garvin Hicking commented on patch set 2 V -1 10/30/26, 21:28

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 10/30/26, 21:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112915