97262[BUGFIX] Sort workspace module by page tree order and label
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/62/97262/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/62/97262/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 3
Issues 3
Files 4
- typo3/sysext/workspaces/Classes/Service/GridDataService.php4+7 −0
- typo3/sysext/workspaces/Tests/Functional/Fixtures/GridData/pages-sorting.csvnew+3 −0
- typo3/sysext/workspaces/Tests/Functional/Fixtures/GridData/tt_content-sorting.csvnew+8 −0
- typo3/sysext/workspaces/Tests/Functional/Service/GridDataServiceTest.php+16 −2
Review log 57
-
Georg Ringer uploaded patch set 1 10/31/26, 14:50
-
Georg Ringer commented on patch set 1 10/31/26, 14:51
This change is ready for review. -
core-ci voted on patch set 1 V +1 10/31/26, 15:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/112962
-
Oli Bartsch commented on patch set 1 11/01/26, 17:25
GridDataService.php:481Sorting by `path_Workspace` orders sibling pages by title, not by `pages.sorting`, and equally named siblings share a path, so their records get mixed under one header. This matches the 13.4.8 behaviour, so it would be fine for this bugfix but we might consider switching to a rootline-based sorting key, which could give real page tree order.GridDataService.php:569The comparator passes `path_Workspace` and `label_Workspace` straight to `strcasecmp()`. Rows can be added or changed by listeners of `AfterCompiledCacheableDataForWorkspaceEvent` and `AfterDataGeneratedForWorkspaceEvent`, so a missing key or `null` would throw a `TypeError` under `strict_types`. Please compare `(string)($a['path_Workspace'] ?? '')` and `(string)($a['label_Workspace'] ?? '')` instead, like the surrounding code does with `??` defaults. -
Georg Ringer uploaded patch set 2
V +111/03/26, 18:55 -
Georg Ringer commented on patch set 2 11/03/26, 18:56
GridDataService.php:481ReplyDoneGridDataService.php:569ReplyDone -
core-ci voted on patch set 2 V +1 11/03/26, 19:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113204