97282[BUGFIX] Clarify fields covered by extendToSubpages
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/82/97282/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/82/97282/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -2 Blocked
- Garvin Hicking -2
- Josua Vogel +1
- Simon Schaufelberger +1
- Benni Mack +1
-
Verified V +1 Needs a vote
- Josua Vogel +1
- Simon Schaufelberger +1
- Benni Mack +1
- core-ci +1 CI
Merge conflicts 9
- main 91304[TASK] Move all LGL labels in core extension to dedicated file and unify syntax
- main 74781[FEATURE] Introduce new slug builders for records and string
- main 95343[FEATURE] Add `adminOnly` for TCA columns
- main 92471[POC] Page Layout Views
- main 90049[FEATURE] Enhance slug generation for folders and spacers
- main 91423[WIP][TASK] Move config values to both section columns and config
- main 92851[WIP][FEATURE] Allow simplified TCA configuration (Test II)
- main 91276[WIP][FEATURE] Switch to list module if page module is on a folder
- main 80074[WIP][!!!][TASK] Improve defaults for translating content
Issues 1
Files 2
Review log 79
-
Georg Ringer uploaded patch set 1 11/01/26, 17:28
-
Georg Ringer commented on patch set 1 11/01/26, 17:29
This change is ready for review. -
core-ci voted on patch set 1 V +1 11/01/26, 17:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113030
-
Georg Ringer rebased onto patch set 2
V +111/06/26, 08:47 -
Benni Mack voted on patch set 2 CR +1 V +1 11/06/26, 08:52
-
core-ci voted on patch set 2 V +1 11/06/26, 09:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113465
-
Josua Vogel voted on patch set 2 CR +1 V +1 11/06/26, 09:10
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/06/26, 09:29
-
Garvin Hicking commented on patch set 2 CR -2 11/06/26, 19:03
Sorry to be a party pooper. But I think this bloats the access panel by a lot. Not only a new line is inserted, but a large description. All other fields don't have such a detailed description. Also it uses labels of fields that if we change them we need to remember those labels are referred to inline. IMO we should rename the label from "Extend to Subpages" to something like "Apply access to sub-pages". We should then do that only to v15, as we should not change the UI for such important fields in internel documentation of projects in an LTS release too much.