Review 14.3 Merged

97287[TASK] Use spl_object_id() for ObjectStorage keys

Benni Mack CR +2 V +2 Normal +69 −16 updated 11/01/26, 21:11

Commit message

PHP 8.6 deprecates spl_object_hash(). Use object IDs for storage and
relation-tracking keys while keeping key() declared to return string.
Its opaque value changes from a hexadecimal hash to a decimal ID.
Positional access continues to resolve through array_values().

Tests cover string iterator keys, distinct object identities, attached
information, detach behavior and dirty relation tracking.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 2

Review log 57

  1. Benni Mack commented on patch set 1 11/01/26, 19:44

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/extbase/Classes/Persistence/ObjectStorage.php * typo3/sysext/extbase/Classes/Validation/Validator/CollectionValidator.php * typo3/sysext/extbase/Tests/Unit/Persistence/ObjectStorageTest.php
  2. core-ci voted on patch set 1 V -1 11/01/26, 19:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113040

  3. Wouter Wolters uploaded patch set 2 V -1 11/01/26, 20:54

  4. core-ci voted on patch set 2 V +1 11/01/26, 21:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113043

  5. Benni Mack marked it ready for review 11/01/26, 21:11

  6. Benni Mack commented on patch set 2 CR +2 V +2 11/01/26, 21:11

    Thanks, Wouter!
  7. Benni Mack merged patch set 3 11/01/26, 21:11