Review main Merged

97300[BUGFIX] Reject non-string dumpFile tokens with 403

Sebastian Michaelsen CR +2 V +2 Normal +128 −1 updated 11/02/26, 17:29

Commit message

FileDumpController passed the token query parameter unchecked to
`hash_equals()`, so `&token[]=x` caused a TypeError and an HTTP 500
status code.

Non-string tokens are now treated as invalid, tests ensure the
behavior.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 912

  1. Sebastian Michaelsen uploaded patch set 1 11/02/26, 14:16

  2. core-ci voted on patch set 1 V +1 11/02/26, 14:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113085

  3. Sebastian Michaelsen uploaded patch set 2 V +1 11/02/26, 14:59

  4. Sebastian Michaelsen marked it ready for review 11/02/26, 15:04

  5. core-ci voted on patch set 2 V +1 11/02/26, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113087

  6. Oliver Klee voted on patch set 2 CR +1 V +1 11/02/26, 16:53

  7. Garvin Hicking uploaded patch set 3 CR +1 V +1 11/02/26, 17:04

  8. Garvin Hicking voted on patch set 3 CR +1 V +1 11/02/26, 17:05

  9. Oliver Klee voted on patch set 3 CR +1 V +1 11/02/26, 17:12

  10. Garvin Hicking voted on patch set 3 CR +2 V +2 11/02/26, 17:15

  11. core-ci voted on patch set 3 V +1 11/02/26, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113096

  12. Garvin Hicking merged patch set 4 11/02/26, 17:29