#111274FileDumpController throws TypeError for array-valued token parameter
Description
If a request to the dumpFile eID passes token as an array, it ends in an uncaught TypeError (HTTP 500) instead of a 403:
https://example.org/?eID=dumpFile&t=f&f=1&token[]=x
TypeError: hash_equals(): Argument #2 ($user_string) must be of type string, array given in typo3/sysext/core/Classes/Controller/FileDumpController.php
FileDumpController::isTokenValid() passes the query parameter on without checking its type:
return hash_equals(
$this->hashService->hmac(implode('|', $parameters), 'resourceStorageDumpFile', HashAlgo::SHA3_256),
$request->getQueryParams()['token'] ?? ''
);
The file declares strict_types=1, so the array isn’t coerced and hash_equals() throws. These requests come from vulnerability scanners and are not a security issue in themselves. But every one of them reaches the exception handler and is logged as an error, which buries real problems in the production log.
Steps to reproduce:
- Request /?eID=dumpFile&t=f&f=1&token[]=x on any frontend.
- The response is a 500 and the log shows the TypeError above.
Expected: a 403 response, the same as for any other invalid token, with no error logged.
Verified on: TYPO3 14.3.10. The same code is on main.
Reviews 2
History 27
-
Sebastian Michaelsen changed description <span data-processor="relativetime" data-value="2026-10-29T08:29:18+00:00" > 10/29/26, 08:29 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 97300 status
NewUnder Review <span data-processor="relativetime" data-value="2026-11-02T14:16:10+00:00" > 11/02/26, 14:16 </span> -
Gerrit Code Review pushed patch set 2 for main to change 97300 <span data-processor="relativetime" data-value="2026-11-02T14:59:07+00:00" > 11/02/26, 14:59 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 97300 <span data-processor="relativetime" data-value="2026-11-02T17:04:46+00:00" > 11/02/26, 17:04 </span>
-
Gerrit Code Review pushed patch set 1 for 14.3 to change 97303 <span data-processor="relativetime" data-value="2026-11-02T17:15:55+00:00" > 11/02/26, 17:15 </span>
-
Gerrit Code Review pushed patch set 2 for 14.3 to change 97303 <span data-processor="relativetime" data-value="2026-11-02T17:16:34+00:00" > 11/02/26, 17:16 </span>
-
Sebastian Michaelsen commented and changed status
Under ReviewResolved done0 %100 % <span data-processor="relativetime" data-value="2026-11-02T17:35:15+00:00" > 11/02/26, 17:35 </span>
Applied in changeset commit:c1bd1373ac43c6573fd48ecdcbdbbc8fdb38e21f.