Review 14.3 Merged

97306[TASK] Avoid PHP 8.6 deprecation in callUserFunction()

Georg Ringer CR +2 V +2 Easy +1 −1 updated 11/02/26, 20:11

Commit message

PHP 8.6 deprecates calling is_a() with a string when allow_string is
false. String callbacks in GeneralUtility::callUserFunction() therefore
trigger a deprecation before they are resolved.

Use instanceof to detect closures without changing callback behavior.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Georg Ringer commented on patch set 1 11/02/26, 19:42

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/02/26, 19:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113102

  3. Georg Ringer voted on patch set 1 CR +2 V +2 11/02/26, 20:11

  4. Georg Ringer merged patch set 2 11/02/26, 20:11