Review 14.3 Merged

97346[TASK] Replace deprecated SORT_LOCALE_STRING flag

Benni Mack CR +2 V +2 Normal +101 −2 updated 11/05/26, 11:58

Commit message

PHP 8.6 deprecates SORT_LOCALE_STRING. Use SORT_STRING for
sortByOptionLabel in the select and country-select ViewHelpers
on PHP 8.6 and newer. Keep locale-aware sorting on older PHP versions.
Preserve option keys and prioritized countries.

Frontend routing sets LC_COLLATE from the site language. Upgrading to
PHP 8.6 can therefore change option order for non-C collations, even
without custom setlocale() calls.

Tests cover numeric, mixed-case and non-ASCII labels, country codes,
priorities and sorting under a non-C locale across PHP versions.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 4

Review log 58

  1. Benni Mack commented on patch set 1 11/04/26, 20:29

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/04/26, 20:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113317

  3. Benni Mack commented on patch set 2 V -1 11/05/26, 09:13

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V -1 11/05/26, 09:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113372

  5. Benni Mack commented on patch set 3 V -1 11/05/26, 09:53

    Published edit on patch set 2.
  6. core-ci voted on patch set 3 V +1 11/05/26, 10:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113381

  7. Benni Mack voted on patch set 3 CR +2 V +2 11/05/26, 11:58

  8. Benni Mack merged patch set 4 11/05/26, 11:58