97377[TASK] Fix PHPStan level 8 findings in extension scanner
Commit message
Review
-
Code review CR +2 Done
- Garvin Hicking +2
-
Verified V +2 Done
- Garvin Hicking +2
- core-ci +1 CI
Issues 1
Files 26
- typo3/sysext/install/Classes/ExtensionScanner/Php/Visitor/GeneratorClassesResolver.php+2 −0
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/AbstractMethodImplementationMatcherTest.php+4 −2
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ArrayDimensionMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ArrayGlobalMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ClassConstantMatcherTest.php+15 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ClassNameMatcherTest.php+2 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ConstantMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ConstructorArgumentMatcherTest.php+10 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/FunctionCallMatcherTest.php+3 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/InterfaceMethodChangedMatcherTest.php+3 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodAnnotationMatcherTest.php+3 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentDroppedMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentDroppedStaticMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentRequiredMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentRequiredStaticMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodArgumentUnusedMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodCallArgumentValueMatcherTest.php+4 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodCallMatcherTest.php+15 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/MethodCallStaticMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/PropertyAnnotationMatcherTest.php+3 −1
Show 6 more files
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/PropertyExistsStaticMatcherTest.php+8 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/PropertyProtectedMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/PropertyPublicMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ScalarStringMatcherTest.php+14 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Visitor/CodeStatisticsTest.php+2 −1
- typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Visitor/GeneratorClassesResolverTest.php+42 −4
Review log 913
-
Garvin Hicking commented on patch set 1 11/05/26, 23:10
Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/PropertyExistsStaticMatcherTest.php -
core-ci voted on patch set 1 V -1 11/05/26, 23:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113425
-
Simon Schaufelberger uploaded patch set 2
V -111/06/26, 00:00 -
core-ci voted on patch set 2 V +1 11/06/26, 00:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113426
-
Simon Schaufelberger uploaded patch set 3
V +111/06/26, 00:16 -
core-ci voted on patch set 3 V +1 11/06/26, 00:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113428
-
Garvin Hicking commented on patch set 3 CR +1 V +1 11/09/26, 12:55
This change is ready for review.Generally this is fine by me, I asked @bo@cedev.de though why the test that is now removed was initially merged, and if there was a need for that which I might not be seeing now. Waiting for feedback before merge. -
Garvin Hicking commented on patch set 3 11/09/26, 12:55
Reply
(This is about `dynamicClassConstantFetchIsIgnored` in `typo3/sysext/install/Tests/Unit/ExtensionScanner/Php/Matcher/ClassConstantMatcherTest.php`) -
Garvin Hicking commented on patch set 3 V 0 CR -1 11/09/26, 13:21
Received Olis feedback, will relay. -
Simon Schaufelberger uploaded patch set 4
CR -1V +111/09/26, 13:34 -
core-ci voted on patch set 4 V +1 11/09/26, 13:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113686
-
Garvin Hicking voted on patch set 4 CR +2 V +2 11/09/26, 13:44
-
Garvin Hicking merged patch set 5 11/09/26, 13:44