Review 14.3 Merged

97400[BUGFIX] Respect extendToSubpages in directory menus

Garvin Hicking CR +2 V +2 Normal +133 −0 updated 11/06/26, 22:12

Commit message

An HMENU with special = directory listed the subpages of a page the
visitor cannot access because of extendToSubpages, and requesting them
was denied afterwards. The menu now checks the rootline of its parent
page the same way the frontend does when a page is requested.

getMenu() stays, since going back to exec_getQuery() would undo the fix
for #96226 and lose showAccessRestrictedPages.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
  • Verified V +2 Done
    • Garvin Hicking +2
    • core-ci +1 CI

Issues 1

Files 3

Review log 69

  1. Garvin Hicking commented on patch set 1 11/06/26, 20:46

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php
  2. Garvin Hicking commented on patch set 2 11/06/26, 20:50

    Published edit on patch set 1.
  3. Garvin Hicking marked it ready for review 11/06/26, 20:50

  4. core-ci voted on patch set 2 V -1 11/06/26, 20:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113528

  5. core-ci voted on patch set 1 V -1 11/06/26, 20:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113526

  6. Garvin Hicking commented on patch set 3 V -1 11/06/26, 21:28

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V +1 11/06/26, 21:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113533

  8. Garvin Hicking voted on patch set 3 CR +2 V +2 11/06/26, 22:12

  9. Garvin Hicking merged patch set 4 11/06/26, 22:12