Review 14.3 Merged

97401[BUGFIX] Allow disabling the XSL stylesheet of XML sitemaps

Georg Ringer CR +2 V +2 Normal +132 −9 updated 11/06/26, 21:39

Commit message

Setting "plugin.tx_seo.config.xslFile" (or the per type or per
sitemap variant) to an empty value made the sitemap fail with an
InvalidSystemResourceIdentifierException, as the empty value was
passed on to the system resource factory.

An empty value now omits the xml-stylesheet processing instruction
and the related Content-Security-Policy mutation. The most specific
setting still wins, so the stylesheet can be disabled globally and
re-enabled for a single sitemap, or the other way round.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 46

  1. Georg Ringer commented on patch set 1 11/06/26, 20:50

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/06/26, 20:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113529

  3. Georg Ringer uploaded patch set 2 V -1 11/06/26, 21:01

  4. core-ci voted on patch set 2 V +1 11/06/26, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113531

  5. Benni Mack voted on patch set 2 CR +2 V +2 11/06/26, 21:38

  6. Benni Mack merged patch set 3 11/06/26, 21:39