Review 14.3 Merged

97423[BUGFIX] Keep page tree refresh flag of nested DataHandler runs

Benni Mack CR +2 V +2 Normal +115 −8 updated 11/09/26, 13:13

Commit message

DataHandler copies, localizes and versions records in nested runs.
When they created records in a workspace or changed pages, only the
nested instance set pagetreeNeedsRefresh, so the DataHandler that was
called reported that no page tree refresh is needed, for example
after copying content with inline children in a workspace. The flag
is now taken over from nested runs, like their error log.

With a reliable flag, the edit form, the visibility toggle of the
list module and the "tce_db" endpoint used by the clipboard and the
modules no longer repeat the conditions of DataHandler and only
evaluate the flag. The edit form now also refreshes the page tree for
commands on pages that are sent without data. The "tce_db" endpoint
now refreshes it for records created in a workspace, and no longer
for page fields that are not shown in the page tree.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 8

Review log 69

  1. Benni Mack commented on patch set 1 11/09/26, 08:32

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/backend/Tests/Functional/Controller/SimpleDataHandlerControllerTest.php * typo3/sysext/core/Classes/DataHandling/DataHandler.php
  2. core-ci voted on patch set 1 V -1 11/09/26, 08:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113629

  3. Benni Mack commented on patch set 2 V -1 11/09/26, 09:15

    Published edit on patch set 1.
  4. Benni Mack marked it ready for review 11/09/26, 09:15

  5. core-ci voted on patch set 2 V -1 11/09/26, 09:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113633

  6. Benni Mack uploaded patch set 3 V -1 11/09/26, 12:58

  7. core-ci voted on patch set 3 V +1 11/09/26, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113677

  8. Benni Mack voted on patch set 3 CR +2 V +2 11/09/26, 13:13

  9. Benni Mack merged patch set 4 11/09/26, 13:13