Review 14.3 Merged

97424[BUGFIX] Resolve packages for download through the TER REST API

Benni Mack CR +2 V +2 Hard +500 −7 updated 11/09/26, 09:59

Commit message

Since #109582 the "Get Extensions" module browses TER live, but
downloads, the dependency check and the update check of installed
extensions still read the imported extension list. An extension
found in the module could not be installed until the list had been
updated.

ExtensionRepository now asks the TER REST API first and falls back
to the imported list when TER does not know an extension, can not be
reached, or "offlineMode" is enabled. A dependency naming a composer
package is resolved to its extension key through the search filter.
Packages resolved from a remote are marked as such, as they have no
database uid anymore.

TER's answer that an extension is unknown is cached, and system
extensions are not asked about at all, since the list of installed
extensions asks about every extension on every view.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 12

Review log 57

  1. Benni Mack commented on patch set 1 11/09/26, 08:38

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/extensionmanager/Classes/Domain/Repository/ExtensionRepository.php
  2. core-ci voted on patch set 1 V -1 11/09/26, 08:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113630

  3. Benni Mack commented on patch set 2 V -1 11/09/26, 09:44

    Published edit on patch set 1.
  4. Benni Mack marked it ready for review 11/09/26, 09:44

  5. core-ci voted on patch set 2 V +1 11/09/26, 09:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113636

  6. Benni Mack voted on patch set 2 CR +2 V +2 11/09/26, 09:59

  7. Benni Mack merged patch set 3 11/09/26, 09:59