Review 14.3 Merged

97433[TASK] Provide more context in IsReferenceConsideredForDependencyEvent

Benni Mack CR +2 V +2 Normal +197 −8 updated 11/09/26, 13:07

Commit message

Introduced tests in #111337 revealed a few shortcomings of the current
dependency resolving during workspace publishing. To be able to address
some of these, more context information is necessary in the
`IsReferenceConsideredForDependencyEvent`.

This patch extends the existing event with 4 properties and getters:

* `getFlexPointer()` allows event listeners to gain more information
  about references from flexform fields
* `getSoftReferenceKey()` and `getSoftReferenceId()` give more context
  to soft references (e. g. links in RTEs)
* `getDirection()` lets event listeners differentiate between parents
  and children resolving by the `DependencyResolver`

Note that this patch doesn't further change the default resolving
strategy in the Core. With this additional context in place, this can
be accomplished in follow-up patches.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 6

Review log 57

  1. Benni Mack commented on patch set 1 11/09/26, 12:49

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/workspaces/Tests/Functional/DataHandler/ChangeStageCommandTest.php * typo3/sysext/workspaces/Tests/Functional/DataHandler/PublishCommandTest.php
  2. Benni Mack uploaded patch set 2 11/09/26, 12:52

  3. Benni Mack marked it ready for review 11/09/26, 12:54

  4. core-ci voted on patch set 1 V -1 11/09/26, 12:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113669

  5. core-ci voted on patch set 2 V +1 11/09/26, 13:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113671

  6. Benni Mack voted on patch set 2 CR +2 V +2 11/09/26, 13:07

  7. Benni Mack merged patch set 3 11/09/26, 13:07