Review main Ready for review

97674[BUGFIX] Flush pages linking to a record when the record changes

Oli Bartsch CR 0 V 0 Hard +288 −6 updated 11/19/26, 12:39

Commit message

With "frontend.cache.autoTagging" enabled, a page rendering a record
link is tagged with the record through ContentObjectRenderer::start()
only if the record can be linked. It is not tagged for a record that
is hidden, not started yet or missing, so the page stays without the
link after the record becomes available. The translation the link is
rendered with is not tagged either, as start() receives the record in
the default language, and record links to the table "pages" are not
tagged at all.

DatabaseRecordLinkBuilder now adds the cache tag <table>_<uid> of the
linked record under the same feature switch, also if the record can
not be linked, with the lifetime of its start and end time, plus the
tag of the translation with the lifetime of the translation.

CacheFlusher now also flushes the tag of the default language record
when a translated record changes. Pages render a translation under the
tag of its default language record, so creating, editing or unhiding
a translation flushes them as well. Page translations are left out.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 4
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/74/97674/4 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/74/97674/4 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 4

  1. main 97436[!!!][FEATURE] Link content elements as records Based on this change Merge conflict Oli Bartsch CR 0 V -1 Expert +1798 −535
  2. main 97675[BUGFIX] Resolve record links in the link preview of the RTE Based on this change Merge conflict Oli Bartsch CR 0 V -1 Hard +265 −32
  3. main 97676[BUGFIX] Resolve site of record redirect targets without site Based on this change Merged Oli Bartsch CR +2 V +2 → 14.3 Normal +244 −5

    The chain has patch set 2 of 4, the changes above it need a rebase.

  4. 97674 [BUGFIX] Flush pages linking to a record when the record changes This change

Issues 1

Files 8

Review log 711

  1. Oli Bartsch uploaded patch set 1 11/15/26, 10:40

  2. core-ci voted on patch set 1 V +1 11/15/26, 10:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114525

  3. Oli Bartsch rebased onto patch set 2 V +1 11/15/26, 11:01

  4. Oli Bartsch uploaded patch set 3 11/15/26, 11:06

  5. core-ci voted on patch set 3 V +1 11/15/26, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114534

  6. core-ci voted on patch set 2 V +1 11/15/26, 11:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114529

  7. Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/16/26, 12:50

  8. Benni Mack commented on patch set 3 CR -1 11/17/26, 19:52

    on it
  9. Benni Mack uploaded patch set 4 CR +1 V +1 11/19/26, 11:46

  10. core-ci voted on patch set 4 V +1 11/19/26, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115005

  11. Benni Mack commented on patch set 4 11/19/26, 12:39

    Reply

    Done
    CacheFlusher now also flushes <table>_<l10n_parent> when a translated record changes (CacheFlushPageResolver::getTranslationParentUid()). Pages render translations under the tag of the default language record, so creating, editing or unhiding a translation now flushes pages linking to the record (and pages showing it as content element). Page translations are left out on purpose. Releases is now main only. Removed the "translations are still not flushed" paragraph from the commit message accordingly.