Review 14.3 Merged

97447[BUGFIX] Keep additional parameters of record links

Benni Mack CR +2 V +2 Normal +220 −4 updated 11/09/26, 16:48

Commit message

Record links (t3://record) dropped every query parameter besides
"identifier" and "uid" when being converted back to a string, e.g.
when RTE content is saved. The "Additional link parameters" field of
the link browser therefore had no effect for record links, although
it works for page links, and cross-language links to records via
"&L=1" were impossible.

The RecordLinkHandler now additionally collects additional parameters
into "parameters" like the PageLinkHandler does, the link browser fills
its parameter field from them, and the frontend passes them on as
query parameters to the link of the record, so "L" or "_language"
select the target language. In that case, the availability of the
record is checked in the target language instead of the current one.

Existing record links with additional arguments, e.g. in link fields
or TypoScript, now render these arguments (plus cHash) in the
frontend, and an "L" argument switches the language of the link.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 7

Review log 610

  1. Benni Mack commented on patch set 1 11/09/26, 15:28

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/frontend/Classes/Typolink/DatabaseRecordLinkBuilder.php
  2. Benni Mack marked it ready for review 11/09/26, 15:49

  3. core-ci voted on patch set 1 V -1 11/09/26, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113725

  4. Benni Mack uploaded patch set 2 V -1 11/09/26, 15:52

  5. core-ci voted on patch set 2 V -1 11/09/26, 16:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113730

  6. core-ci commented on patch set 2 11/09/26, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113730

  7. Benni Mack uploaded patch set 3 V -1 11/09/26, 16:31

  8. core-ci voted on patch set 3 V +1 11/09/26, 16:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113739

  9. Benni Mack voted on patch set 3 CR +2 V +2 11/09/26, 16:48

  10. Benni Mack merged patch set 4 11/09/26, 16:48