Review 14.3 Merged

97477[BUGFIX] Only resolve version ids for workspace-aware MM relations

Benni Mack CR +2 V +2 Normal +147 −1 updated 11/10/26, 05:28

Commit message

The migration of RelationHandler to the Schema API inverted the
check in convertItemArray(): workspace-aware tables were skipped and
tables without versioning were run through the version overlay
resolution instead.

For tables without versioning, PlainDataResolver returns the ids
as a plain list. The lookup by uid then used the uid as a list
index, so several items could end up with the same id. Saving an
MM select in a workspace then failed on a duplicate primary key.

The check is restored, so only workspace-aware tables get their
live ids converted to version ids.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 7

Review log 58

  1. Benni Mack commented on patch set 1 11/09/26, 21:19

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/09/26, 21:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113797

  3. Benni Mack commented on patch set 2 V -1 11/09/26, 21:43

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V -1 11/09/26, 21:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113804

  5. Georg Ringer uploaded patch set 3 V -1 11/09/26, 22:11

  6. core-ci voted on patch set 3 V +1 11/09/26, 22:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113815

  7. Benni Mack voted on patch set 3 CR +2 V +2 11/10/26, 05:28

  8. Benni Mack merged patch set 4 11/10/26, 05:28