Review 14.3 Merged

97478[BUGFIX] Add noreferrer for links even if site with host is configured

Benni Mack CR +2 V +2 Normal +32 −31 updated 11/09/26, 22:16

Commit message

The decision whether to add the rel="noreferrer" attribute to links was
based on the locally configured sites of the TYPO3 instance. This is now
changed to only check for the request host. Only if request host and
URL host are identical, the attribute can be safely omitted.

It should not matter if a site is hosted on the same system. An external
link should always include the noreferrer attribute, even if you can
"trust yourself".

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 711

  1. Benni Mack commented on patch set 1 11/09/26, 21:21

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/frontend/Tests/Functional/ContentObject/ContentObjectRendererTest.php * typo3/sysext/frontend/Tests/Functional/Typolink/LinkFactoryTest.php
  2. Benni Mack commented on patch set 2 11/09/26, 21:23

    Published edit on patch set 1.
  3. Benni Mack marked it ready for review 11/09/26, 21:23

  4. core-ci voted on patch set 1 V -1 11/09/26, 21:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113798

  5. core-ci voted on patch set 2 V -1 11/09/26, 21:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113799

  6. Benni Mack commented on patch set 3 V -1 11/09/26, 21:45

    Published edit on patch set 2.
  7. core-ci voted on patch set 3 V -1 11/09/26, 22:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113808

  8. Georg Ringer commented on patch set 4 V -1 11/09/26, 22:03

    Published edit on patch set 3.
  9. core-ci voted on patch set 4 V +1 11/09/26, 22:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113812

  10. Georg Ringer voted on patch set 4 CR +2 V +2 11/09/26, 22:16

  11. Georg Ringer merged patch set 5 11/09/26, 22:16