Review 14.3 Merged

97480[BUGFIX] Keep page path in section links if current URL has arguments

Georg Ringer CR +2 V +2 Easy +31 −0 updated 11/10/26, 05:29

Commit message

A typolink to a section of the current page was rendered as a bare
"#fragment" whenever the link itself had no query parameters. If the
current request carried query or route arguments, such as the
"forgot password" view of felogin or the detail view of a route
enhancer, the browser stayed on that view instead of returning to
the plain page.

The fragment-only shortcut is now taken only if the current request
has no arguments as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Georg Ringer commented on patch set 1 11/09/26, 21:47

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/09/26, 22:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113809

  3. Georg Ringer uploaded patch set 2 V -1 11/09/26, 22:08

  4. core-ci voted on patch set 2 V +1 11/09/26, 22:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113814

  5. Benni Mack voted on patch set 2 CR +2 V +2 11/10/26, 05:29

  6. Benni Mack merged patch set 3 11/10/26, 05:29