Review 14.3 Merged

97481[BUGFIX] Validate slug field after the proposal has been applied

Georg Ringer CR +2 V +2 Normal +45 −7 updated 11/10/26, 05:31

Commit message

The slug element dispatched the "change" event before the new
proposal was written into its fields. FormEngine validation therefore
checked the outdated value, so a required slug field stayed marked as
invalid, also after clicking "Recalculate URL segment".

For generated proposals (automatic or recalculated), the proposal is
now applied first and the event dispatched afterwards, also if only the
visible input differs from the proposal. Manually entered slugs no
longer dispatch the event, as they are already validated while typing.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 34

  1. Georg Ringer commented on patch set 1 11/09/26, 22:04

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/09/26, 22:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113813

  3. Benni Mack voted on patch set 1 CR +2 V +2 11/10/26, 05:31

  4. Benni Mack merged patch set 2 11/10/26, 05:31