Review 13.4 Merged

97493[BUGFIX] Only resolve version ids for workspace-aware MM relations

Benni Mack CR +2 V +2 Normal +149 −1 updated 11/10/26, 06:41

Commit message

The migration of RelationHandler to the Schema API inverted the
check in convertItemArray(): workspace-aware tables were skipped and
tables without versioning were run through the version overlay
resolution instead.

For tables without versioning, PlainDataResolver returns the ids
as a plain list. The lookup by uid then used the uid as a list
index, so several items could end up with the same id. Saving an
MM select in a workspace then failed on a duplicate primary key.

The check is restored, so only workspace-aware tables get their
live ids converted to version ids.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 8

Review log 711

  1. Benni Mack commented on patch set 1 11/10/26, 05:30

    Cherry Picked from branch 14.3. The following files contain Git conflicts: * typo3/sysext/core/Tests/Functional/Database/RelationHandlerTest.php
  2. Benni Mack commented on patch set 2 11/10/26, 05:30

    Published edit on patch set 1.
  3. core-ci voted on patch set 1 V -1 11/10/26, 05:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113830

  4. core-ci voted on patch set 2 V -1 11/10/26, 05:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113831

  5. Benni Mack commented on patch set 3 V -1 11/10/26, 05:54

    Published edit on patch set 2.
  6. Benni Mack marked it ready for review 11/10/26, 05:54

  7. core-ci voted on patch set 3 V -1 11/10/26, 06:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113832

  8. Benni Mack uploaded patch set 4 V -1 11/10/26, 06:24

  9. core-ci voted on patch set 4 V +1 11/10/26, 06:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113837

  10. Benni Mack voted on patch set 4 CR +2 V +2 11/10/26, 06:41

  11. Benni Mack merged patch set 5 11/10/26, 06:41