Review 14.3 Merged

97501[BUGFIX] Complete partially configured default crop variant

Benni Mack CR +2 V +2 Normal +73 −0 updated 11/10/26, 08:23

Commit message

The image manipulation element drops its built-in "default" crop
variant as soon as any cropVariants configuration is given. Changing
a single option of the default variant, e.g. its selectedRatio via
TCEFORM or overrideChildTca, therefore resulted in a variant without
aspect ratios and the exception 1620147893.

A configured crop variant matching a built-in variant now receives
the missing options from it. Options which are configured explicitly,
such as a custom list of allowed aspect ratios, are kept as they are,
and custom crop variants are not extended with the default variant.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 34

  1. Benni Mack commented on patch set 1 11/10/26, 08:01

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/10/26, 08:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113855

  3. Benni Mack voted on patch set 1 CR +2 V +2 11/10/26, 08:23

  4. Benni Mack merged patch set 2 11/10/26, 08:23