Review main Ready for review

97522[BUGFIX] Keep field change items of the link browser valid

Georg Ringer CR 0 V 0 Easy +29 −6 updated 11/10/26, 20:07

Commit message

The link browser receives the field change items of the opening
field as URL query parameters, protected by an HMAC. The HMAC is now
built from the query string representation of the items, which is
identical before and after the round trip through the URL.

Items containing boolean values, like the confirmation flag of the
reload behavior, are accepted again. Link fields configured with
`onChange = reload` therefore trigger the reload after a link has
been selected in the link browser.

The styleguide field `link_1` is configured with `onChange = reload`
to make this testable.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/22/97522/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/22/97522/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 3

Issues 1

Files 4

Review log 23

  1. Georg Ringer uploaded patch set 1 11/10/26, 19:59

  2. Georg Ringer commented on patch set 1 11/10/26, 20:00

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 11/10/26, 20:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113943