Review main Ready for review

97545[BUGFIX] Synchronize fe_group of page translations

Torben Hansen CR 0 V 0 Hard +344 −1 updated 11/12/26, 14:55

Commit message

Since the "fe_group" column of "pages" is generated by
the TCA enrichment (#104311), it lost its "l10n_mode"
setting "exclude". Editors could therefore set an access
restriction on a page translation. Access is checked on
the default language page only, but the translated value
replaces the default value in page language overlays,
e.g. for the "USR" state of menus.

The "fe_group" field of "pages" uses "l10n_mode" set to
"exclude" again, so the value is synchronized from the
default language page and can no longer be changed on a
translation.

Page language overlays keep the "fe_group" value of the
default language page, so deviating values stored in
existing translations are ignored.

An upgrade wizard copies the value of live default
language pages to their live translations, where it
deviates.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/45/97545/3 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/45/97545/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 4

Issues 2

Files 10

Review log 912

  1. Torben Hansen uploaded patch set 1 11/11/26, 15:05

  2. core-ci voted on patch set 1 V +1 11/11/26, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114103

  3. Benni Mack commented on patch set 1 11/11/26, 15:32

    I assume this needs an update wizard?
  4. Torben Hansen commented on patch set 1 11/11/26, 15:41

    Reply

    Unsure. Basically it has no effect currently defining a different fe_group for a translated page, since it is not evaluated. The update wizard would only be for consistency reasons.
  5. Georg Ringer voted on patch set 1 CR +1 V +1 11/11/26, 20:32

  6. Benni Mack commented on patch set 1 CR -2 11/11/26, 21:14

    Reply

    I will take care of this.
  7. Benni Mack uploaded patch set 2 CR +1 V +1 11/12/26, 14:29

    Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**")
  8. Benni Mack voted on patch set 2 CR 0 11/12/26, 14:29

  9. Benni Mack commented on patch set 2 11/12/26, 14:30

    Reply

    we can ship the upgrade wizard only on main, I'm fine with that.
  10. core-ci voted on patch set 2 V +1 11/12/26, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114193

  11. Benni Mack uploaded patch set 3 V +1 11/12/26, 14:42

  12. core-ci voted on patch set 3 V +1 11/12/26, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114195