97545[BUGFIX] Synchronize fe_group of page translations
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/45/97545/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/45/97545/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 4
Issues 2
Files 10
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+8 −1
- typo3/sysext/core/Classes/Upgrades/PageTranslationFeGroupMigration.phpnew+111 −0
- typo3/sysext/core/Configuration/TCA/Overrides/pages.php+3 −0
- typo3/sysext/core/Documentation/Changelog/13.4.x/Important-111411-PageTranslationsInheritUsergroupAccessRights.rstnew+54 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/PageTranslationFeGroup/pages.csvnew+4 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/PageTranslationFeGroupTest.phpnew+75 −0
- typo3/sysext/core/Tests/Functional/Domain/Repository/PageRepositoryTest.php+24 −0
- typo3/sysext/core/Tests/Functional/Upgrades/Fixtures/PageTranslationFeGroupBase.csvnew+11 −0
- typo3/sysext/core/Tests/Functional/Upgrades/Fixtures/PageTranslationFeGroupMigrated.csvnew+11 −0
- typo3/sysext/core/Tests/Functional/Upgrades/PageTranslationFeGroupMigrationTest.phpnew+43 −0
Review log 912
-
Torben Hansen uploaded patch set 1 11/11/26, 15:05
-
core-ci voted on patch set 1 V +1 11/11/26, 15:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114103
-
Benni Mack commented on patch set 1 11/11/26, 15:32
I assume this needs an update wizard? -
Torben Hansen commented on patch set 1 11/11/26, 15:41
Reply
Unsure. Basically it has no effect currently defining a different fe_group for a translated page, since it is not evaluated. The update wizard would only be for consistency reasons. -
Georg Ringer voted on patch set 1 CR +1 V +1 11/11/26, 20:32
-
Benni Mack commented on patch set 1 CR -2 11/11/26, 21:14
Reply
I will take care of this. -
Benni Mack uploaded patch set 2
CR +1V +111/12/26, 14:29Copied Votes: * Code-Review-2 (copy condition: "changekind:NO_CHANGE OR **is:MIN**") -
Benni Mack voted on patch set 2 CR 0 11/12/26, 14:29
-
Benni Mack commented on patch set 2 11/12/26, 14:30
Reply
we can ship the upgrade wizard only on main, I'm fine with that. -
core-ci voted on patch set 2 V +1 11/12/26, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114193
-
Benni Mack uploaded patch set 3
V +111/12/26, 14:42 -
core-ci voted on patch set 3 V +1 11/12/26, 14:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114195