95929[BUGFIX] Language field must not be an exclude field
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 4
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/29/95929/4 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/29/95929/4 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V -1 Blocked
- core-ci -1 CI
Merge conflicts 10
- main 97545[BUGFIX] Synchronize fe_group of page translations
- main 92191[WIP][TASK] Migrate PageTree to Action API
- main 97164[BUGFIX] Ask for required fields when translating a page
- main 96653[!!!][TASK] Restrict TCA overrides for types and special values
- main 95105[TASK] Apply PHP code simplifications
- main 95343[FEATURE] Add `adminOnly` for TCA columns
- main 95042[WIP][BUGFIX] Restrict selectable items of transOrigPointerField
- main 91423[WIP][TASK] Move config values to both section columns and config
- main 92847[WIP][FEATURE] Allow simplified TCA configuration
- main 92851[WIP][FEATURE] Allow simplified TCA configuration (Test II)
Issues 1
Files 13
- typo3/sysext/backend/Tests/Functional/Localization/Fixtures/be_users_editor.csvnew+6 −0
- typo3/sysext/backend/Tests/Functional/Localization/Fixtures/be_users_language_restricted.csvnew+6 −0
- typo3/sysext/backend/Tests/Functional/Localization/ManualLocalizationHandlerTest.php+130 −0
- typo3/sysext/core/Classes/Configuration/Tca/TcaEnrichment.php+0 −1
- typo3/sysext/core/Classes/Configuration/Tca/TcaMigration.php+30 −0
- typo3/sysext/core/Classes/Schema/Field/LanguageFieldType.php+5 −0
- typo3/sysext/core/Configuration/TCA/Overrides/pages.php+0 −3
- typo3/sysext/core/Configuration/TCA/Overrides/sys_file_metadata.php+0 −3
- typo3/sysext/core/Configuration/TCA/Overrides/sys_file_reference.php+1 −2
- typo3/sysext/core/Documentation/Changelog/15.0/Important-76274-LanguageFieldIsNoLongerAnExcludeField.rstnew+59 −0
- typo3/sysext/core/Tests/Unit/Configuration/Tca/TcaEnrichmentTest.php+0 −1
- typo3/sysext/core/Tests/Unit/Configuration/Tca/TcaMigrationTest.php+20 −0
- typo3/sysext/extbase/Tests/Functional/Fixtures/Extensions/extbase_upload/Configuration/TCA/tx_extbaseupload_domain_model_singlefile.php+0 −1
Review log 812
-
Georg Ringer uploaded patch set 1 09/19/26, 11:12
-
core-ci voted on patch set 1 V -1 09/19/26, 12:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/108845
-
Benni Mack commented on patch set 1 10/02/26, 14:10
lets do this, for 15.0 -
Georg Ringer uploaded patch set 2
V -110/02/26, 16:05 -
Georg Ringer commented on patch set 2 10/02/26, 16:06
This change is ready for review. -
Daniel Windloff commented on patch set 2 10/02/26, 16:19
For the TCA Schema field `LanguageFieldType` the method `supportsAccessControl()` should be implemented with fixed return value to false. Adding this method, the behavior should be fixed. Atm you could add exlude in types column overwrites and get the not intended behavior. -
core-ci voted on patch set 2 V -1 10/02/26, 16:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109967
-
Georg Ringer uploaded patch set 3
V -110/02/26, 16:28 -
Georg Ringer commented on patch set 3 10/02/26, 16:28
Reply
Good point, thanks! LanguageFieldType::supportsAccessControl() now always returns false, covered by a unit test, so an exclude flag from columnsOverrides no longer affects DataHandler. The TCA migration stays to notify integrators and clean up the column definition. -
core-ci voted on patch set 3 V -1 10/02/26, 16:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/109972
-
Georg Ringer uploaded patch set 4
V -111/09/26, 21:10 -
core-ci voted on patch set 4 V -1 11/09/26, 21:38 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/113793