97564[BUGFIX] Ignore plain string in file upload type converter
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/64/97564/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/64/97564/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Josua Vogel +1
-
Verified V +1 Needs a vote
- Josua Vogel +1
- core-ci +1 CI
Merge conflicts 1
Issues 1
Files 2
Review log 69
-
Georg Ringer uploaded patch set 1 11/11/26, 20:29
-
Georg Ringer commented on patch set 1 11/11/26, 20:30
This change is ready for review. -
core-ci voted on patch set 1 V -1 11/11/26, 20:43 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114143
-
Oli Bartsch commented on patch set 1 11/14/26, 09:57
UploadedFileReferenceConverter.php:172IMO this is currently not correct. We need to remove the early return above and properly check for array here. Additionally we might even change doc comment as string will always lead to null. ```suggestion if (!is_array($source) || $source === []) { ``` -
core-ci voted on patch set 1 V +1 11/18/26, 10:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114143
-
Georg Ringer uploaded patch set 2
V +111/19/26, 17:20 -
Georg Ringer commented on patch set 2 11/19/26, 17:21
UploadedFileReferenceConverter.php:172ReplyDone -
core-ci voted on patch set 2 V +1 11/19/26, 17:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115031
-
Josua Vogel voted on patch set 2 CR +1 V +1 11/20/26, 09:26