Review main Ready for review

97567[BUGFIX] Resolve translated records to own uid with fallback type free

Georg Ringer CR -2 V 0 Normal +77 −2 updated 11/19/26, 17:40

Commit message

PersistedAliasMapper and PersistedPatternMapper now resolve a route
value to the uid of the matching record itself if the site language
uses the fallback type "free". Translated records of such a language
are independent of the default language, so the language parent is no
longer used. The generated slug and the resolved record now belong
to the same translation.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 5
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/67/97567/5 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/67/97567/5 && git cherry-pick FETCH_HEAD

Review

  • Code review CR -2 Blocked
    • Benni Mack -2
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 2

Issues 2

Files 5

Review log 1318

  1. Georg Ringer uploaded patch set 1 11/11/26, 22:20

  2. Georg Ringer commented on patch set 1 11/11/26, 22:20

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 11/11/26, 22:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114148

  4. Benni Mack uploaded patch set 2 V +1 11/12/26, 19:50

  5. core-ci voted on patch set 2 V +1 11/12/26, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114217

  6. Benni Mack voted on patch set 2 CR +1 V +1 11/12/26, 20:23

  7. Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/14/26, 20:11

  8. Benni Mack updated the commit message in patch set 3 CR +1 V +1 11/15/26, 14:04

  9. Benni Mack rebased onto patch set 4 11/15/26, 14:04

  10. Benni Mack voted on patch set 4 CR +1 V +1 11/15/26, 14:04

  11. core-ci voted on patch set 3 V +1 11/15/26, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114539

  12. core-ci voted on patch set 4 V +1 11/15/26, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114540

  13. André Buchmann commented on patch set 4 11/15/26, 19:44

    Thx for the patch. I've tested it in one of our real projects: With the patch we can remove some of our workarounds in e.g. News Controller XClass. However other parts which compare default uids break. The patch changes which uid gets passed to the controller, and any project that relies on the parent uid in free mode silently breaks. Therefore I think it's breaking and shouldn't be put into 14.3.
  14. Benni Mack commented on patch set 4 11/17/26, 17:03

    Reply

    I'm curious to know what would break, because if this is the case, we should document (and test) this.
  15. Georg Ringer uploaded patch set 5 CR +1 V +1 11/19/26, 17:31

  16. Georg Ringer commented on patch set 5 11/19/26, 17:32

    Reply

    Done
  17. Benni Mack commented on patch set 5 CR -2 11/19/26, 17:36

    Unresolved

    I think I need to wait on this.
  18. core-ci voted on patch set 5 V +1 11/19/26, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115033