97567[BUGFIX] Resolve translated records to own uid with fallback type free
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 5
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/67/97567/5 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/67/97567/5 && git cherry-pick FETCH_HEAD
Review
-
Code review CR -2 Blocked
- Benni Mack -2
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 2
Issues 2
Files 5
- typo3/sysext/core/Classes/Routing/Aspect/PersistedAliasMapper.php+1 −1
- typo3/sysext/core/Classes/Routing/Aspect/PersistedPatternMapper.php+1 −1
- typo3/sysext/core/Documentation/Changelog/14.3.x/Important-102604-PersistedRouteMappersReturnTranslationUidWithFreeFallback.rstnew+31 −0
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedAliasMapperTest.php+22 −0
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedPatternMapperTest.php+22 −0
Review log 1318
-
Georg Ringer uploaded patch set 1 11/11/26, 22:20
-
Georg Ringer commented on patch set 1 11/11/26, 22:20
This change is ready for review. -
core-ci voted on patch set 1 V +1 11/11/26, 22:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114148
-
Benni Mack uploaded patch set 2
V +111/12/26, 19:50 -
core-ci voted on patch set 2 V +1 11/12/26, 19:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114217
-
Benni Mack voted on patch set 2 CR +1 V +1 11/12/26, 20:23
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/14/26, 20:11
-
Benni Mack updated the commit message in patch set 3
CR +1V +111/15/26, 14:04 -
Benni Mack rebased onto patch set 4 11/15/26, 14:04
-
Benni Mack voted on patch set 4 CR +1 V +1 11/15/26, 14:04
-
core-ci voted on patch set 3 V +1 11/15/26, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114539
-
core-ci voted on patch set 4 V +1 11/15/26, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114540
-
André Buchmann commented on patch set 4 11/15/26, 19:44
Thx for the patch. I've tested it in one of our real projects: With the patch we can remove some of our workarounds in e.g. News Controller XClass. However other parts which compare default uids break. The patch changes which uid gets passed to the controller, and any project that relies on the parent uid in free mode silently breaks. Therefore I think it's breaking and shouldn't be put into 14.3. -
Benni Mack commented on patch set 4 11/17/26, 17:03
Reply
I'm curious to know what would break, because if this is the case, we should document (and test) this. -
Georg Ringer uploaded patch set 5
CR +1V +111/19/26, 17:31 -
Georg Ringer commented on patch set 5 11/19/26, 17:32
Reply
Done -
Benni Mack commented on patch set 5 CR -2 11/19/26, 17:36
Unresolved
I think I need to wait on this. -
core-ci voted on patch set 5 V +1 11/19/26, 17:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115033