Review main Merged

97571[BUGFIX] Align MFA form element with MFA module and Ajax access

Oli Bartsch CR +2 V +2 Normal +81 −19 updated 11/19/26, 11:47

Commit message

The "mfa" form element links to the MFA module to set up or manage
multi-factor authentication. The module always operates on the
logged-in backend user, but the link was rendered for every user
record without MFA, including other backend users and frontend users.
An administrator editing another user ended up with their own MFA
configuration. The description and the link are now only rendered
when the edited record is the current backend user.

Additionally, the element rendered the deactivation buttons for
non-admin users in the user settings, while the Ajax endpoint only
allows admins to deactivate providers. The request was rejected with
"insufficient permissions". The buttons are now only rendered for
admins, editors manage their providers in the MFA module.

The entries of the provider list are now vertically centered, so
the title no longer sticks to the top next to the deactivation button.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1013

  1. Oli Bartsch uploaded patch set 1 11/12/26, 08:33

  2. core-ci voted on patch set 1 V +1 11/12/26, 08:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114170

  3. Josua Vogel commented on patch set 1 11/12/26, 09:54

    MfaInfoElement.php:129

    $currentBackendUser->getUserId()
  4. Oli Bartsch uploaded patch set 2 V +1 11/14/26, 10:06

  5. Oli Bartsch commented on patch set 2 11/14/26, 10:07

    MfaInfoElement.php:129 Reply

    Done
  6. core-ci voted on patch set 2 V -1 11/14/26, 10:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114426

  7. Oli Bartsch rebased onto patch set 3 V -1 11/14/26, 11:07

  8. core-ci voted on patch set 3 V +1 11/14/26, 11:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114443

  9. Josua Vogel voted on patch set 3 CR +1 V +1 11/16/26, 12:44

  10. Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/18/26, 01:39

  11. Benni Mack voted on patch set 3 CR +1 V +1 11/19/26, 09:58

  12. Benni Mack voted on patch set 3 CR +2 V +2 11/19/26, 11:47

  13. Benni Mack merged patch set 4 11/19/26, 11:47