Review 14.3 Merged

97580[BUGFIX] Preserve form finisher select values

Oli Bartsch CR +2 V +2 Hard +871 −27 updated 11/14/26, 09:59

Commit message

Form finisher options provide FormEngine configuration for rendering
fields inside FlexForm overrides. This configuration was passed through
`TranslationService::translateValuesRecursive()` as a whole. The form
editor translated its definitions the same way.

As a result, not only labels but also technical configuration values
were translated. The item value "default" of the `translation.language`
option of email finishers was stored as its backend label, for example
"Default" or "Standard", in form plugins and in form definitions. Such
a value matches no configured item and forces emails into the default
language.

Restrict translation of FlexForm overrides to textual FormEngine
properties: labels, descriptions, placeholders, section titles, labels
of item groups and labels of legacy numeric select items. The form
editor keeps the values of select options untranslated.

An upgrade wizard replaces every non-empty value of the option that is
not a valid language key by "default" in form plugins and in form
definitions stored in the database. An Important changelog entry
documents the new translation behavior and the migration.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
  • Verified V +2 Done
    • Oli Bartsch +2
    • core-ci +1 CI

Issues 1

Files 13

Review log 34

  1. Oli Bartsch uploaded patch set 1 11/12/26, 16:34

  2. core-ci voted on patch set 1 V +1 11/12/26, 16:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114200

  3. Oli Bartsch voted on patch set 1 CR +2 V +2 11/14/26, 09:58

  4. Oli Bartsch merged patch set 2 11/14/26, 09:59