Review 14.3 Merged

97582[BUGFIX] Check access before localizing child records

Benni Mack CR +2 V +2 Normal +213 −0 updated 11/12/26, 19:03

Commit message

DataHandler::localizeRecord() localizes child records such as file
references while it processes the fields of the record. The localized
record itself was only checked later, when it went through the datamap.
When only that record was rejected, for example because the editor is
not allowed to use its CType or may not modify its table, the localized
children stayed behind, still attached to the default language record.

The record to be localized is now checked for table modify access,
insert permission on the destination page and record edit access
before any child record is written.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 2

Files 8

Review log 46

  1. Benni Mack commented on patch set 1 11/12/26, 18:30

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/12/26, 18:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114207

  3. Benni Mack commented on patch set 2 V -1 11/12/26, 18:41

    Published edit on patch set 1.
  4. core-ci voted on patch set 2 V +1 11/12/26, 18:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114208

  5. Benni Mack voted on patch set 2 CR +2 V +2 11/12/26, 19:03

  6. Benni Mack merged patch set 3 11/12/26, 19:03