97584[TASK] Avoid repeated page access checks for inline children
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/84/97584/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/84/97584/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Simon Schaufelberger +1
-
Verified V +1 Needs a vote
- Simon Schaufelberger +1
- core-ci +1 CI
Merge conflicts 5
- main 97304[WIP][BUGFIX] Render the record form from unsaved values
- main 97558[BUGFIX] Lock synchronized inline and file relations in translations
- main 96543[WIP][POC][TASK] Write and read records by the same rules and rights
- main 95145[TASK] Migrate LanguageService->sL() labels to new domain syntax
- main 92180[!!!][TASK] Decouple registration of FormEngine nodes from NodeFactory
Issues 1
Files 5
- typo3/sysext/backend/Classes/Form/Container/FileReferenceContainer.php+2 −19
- typo3/sysext/backend/Classes/Form/Container/InlineRecordContainer.php2+5 −2
- typo3/sysext/backend/Tests/Functional/Form/Container/Fixtures/InlineRecordContainer.csvnew+17 −0
- typo3/sysext/backend/Tests/Functional/Form/Container/FileReferenceContainerTest.php+20 −2
- typo3/sysext/backend/Tests/Functional/Form/Container/InlineRecordContainerTest.phpnew+144 −0
Review log 57
-
Benni Mack uploaded patch set 1 11/12/26, 18:50
-
core-ci voted on patch set 1 V +1 11/12/26, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114210
-
Oli Bartsch commented on patch set 1 11/13/26, 16:16
-
Benni Mack uploaded patch set 2
V +111/13/26, 17:23 -
Benni Mack commented on patch set 1 11/13/26, 17:48
InlineRecordContainer.php:376ReplyDone in PS2: the commit message now mentions it, and `InlineRecordContainerTest` has a test for a root-level child as an editor (it fails without the patch). -
Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/13/26, 18:31
-
core-ci voted on patch set 2 V +1 11/13/26, 19:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114364
InlineRecordContainer.php:376