Review main Ready for review

97558[BUGFIX] Lock synchronized inline and file relations in translations

Benni Mack CR +1 V +1 Hard +371 −14 updated 11/13/26, 10:06

Commit message

Inline and file fields with "allowLanguageSynchronization" offered all
controls to create, delete, hide and sort relations in a translated
record, even while the field followed the default or source language.
DataHandler discards such changes on save and synchronizes the
relations from the language parent instead, so editors lost their
changes without notice.

As long as a relation field follows its language parent, the controls
to add, remove, hide, sort and localize its relations are now removed.
The fields of the child records stay editable, as their values belong
to the translation, e.g. the alternative text of an image.

Changing the localization state of such a field saves and reloads the
record, as the relations need to be rendered again in the new state.
Cancelling the confirmation restores the previous state.

The styleguide inline 1:n table gets a field with
"allowLanguageSynchronization" to cover inline relations in the
end-to-end test next to the existing file field.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/58/97558/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/58/97558/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Simon Schaufelberger +1
  • Verified V +1 Needs a vote
    • Simon Schaufelberger +1
    • core-ci +1 CI

Relation chain 2

  1. main 96817[BUGFIX] Avoid orphaned children for synchronized translations Based on this change Benni Mack CR 0 V 0 → 14.3 DataHandler Normal +142 −3
  2. 97558 [BUGFIX] Lock synchronized inline and file relations in translations This change

Merge conflicts 23

Issues 1

Files 12

Review log 35

  1. Benni Mack uploaded patch set 1 11/11/26, 16:45

  2. core-ci voted on patch set 1 V +1 11/11/26, 16:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114131

  3. Benni Mack uploaded patch set 2 V +1 11/13/26, 09:25

  4. core-ci voted on patch set 2 V +1 11/13/26, 09:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114292

  5. Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/13/26, 10:06