Review 14.3 Merged

97585[BUGFIX] Prevent parent loops in category tree

Benni Mack CR +2 V +2 Hard +296 −2 updated 11/12/26, 19:29

Commit message

When editing the parent field of a record in a tree relation to its own
table, only the record itself was unselectable. Its descendants could
still be chosen, which created a loop and detached the whole subtree
from the tree.

When the edited field is the parent field of the tree, all descendants
of the record are now resolved and marked unselectable as well. They
are looked up in the available items and in the database, so they are
also found if the displayed tree is re-rooted by starting points or
category mounts, or if an intermediate item is removed via TSconfig.

When a workspace version is edited, the live record and its
descendants are marked unselectable, as the tree lists live uids.

Trees using "childrenField" are not covered by this change.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 5

Review log 34

  1. Benni Mack commented on patch set 1 11/12/26, 19:13

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 11/12/26, 19:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114213

  3. Benni Mack voted on patch set 1 CR +2 V +2 11/12/26, 19:29

  4. Benni Mack merged patch set 2 11/12/26, 19:29