97589[BUGFIX] Avoid "database is locked" when resolving page slugs
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 3
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/89/97589/3 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/89/97589/3 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Merge conflicts 1
Issues 1
Files 3
Review log 811
-
Benni Mack uploaded patch set 1 11/12/26, 20:27
-
Benni Mack updated the commit message in patch set 2 11/12/26, 20:28
-
core-ci voted on patch set 1 V +1 11/12/26, 20:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114225
-
core-ci voted on patch set 2 V +1 11/12/26, 20:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114226
-
Markus Klein commented on patch set 2 11/12/26, 21:24
Are we sure this is only a problem for that specific case? To me this reads like: any concurrent write to longer reads could have the same problem. While it seems reasonable in this case to grab all pages into memory and free the connection, this is not feasible in general, I'd say. -
Benni Mack commented on patch set 2 11/13/26, 09:25
Reply
it happened while having 3 parallel runs for the e2e tests locally, where I wanted to share an instance and the whole thing failed because of that. the fix is however not just SQLite only... -
Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/13/26, 10:13
-
Benni Mack uploaded patch set 3
CR +1V +111/13/26, 15:33 -
core-ci voted on patch set 3 V +1 11/13/26, 18:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114355
-
Benni Mack marked it work in progress 11/18/26, 19:21
-
Benni Mack commented on patch set 3 11/18/26, 19:22
Reply Unresolved
I think we should see if this happens further while we're improving e2e tests, but lets wait on it for the time being