Review 14.3 Merged

97600[BUGFIX] Read form metadata as complete YAML values

Benni Mack CR +2 V +2 Normal +181 −32 updated 11/19/26, 15:32

Commit message

The metadata of form definition files (identifier, type, label and
prototypeName) is read line by line to avoid parsing complete files.
Values were taken from their first line only, so multi-line, quoted
or commented values ended up empty, truncated or with the comment.

Each metadata key is now parsed together with its following indented
lines by the YAML parser. Other parts of the file are still skipped,
so listing forms stays fast.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 6

Review log 69

  1. Benni Mack commented on patch set 1 11/13/26, 09:27

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/form/Classes/Upgrades/FileFormsToDatabaseUpgradeWizard.php
  2. core-ci voted on patch set 1 V -1 11/13/26, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114293

  3. Benni Mack uploaded patch set 2 V -1 11/13/26, 14:03

  4. core-ci voted on patch set 2 V -1 11/13/26, 14:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114328

  5. Georg Ringer uploaded patch set 3 V -1 11/14/26, 21:04

  6. Georg Ringer commented on patch set 3 11/14/26, 21:06

    This change is ready for review.
  7. core-ci voted on patch set 3 V +1 11/14/26, 21:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114490

  8. Benni Mack voted on patch set 3 CR +2 V +2 11/19/26, 15:32

  9. Benni Mack merged patch set 4 11/19/26, 15:32