Review 14.3 Merged

97602[BUGFIX] Fire somePropertyChanged event for defaultValue in PropertyGridEditor

Benni Mack CR +2 V +2 Easy +12 −4 updated 11/13/26, 14:18

Commit message

When toggling the "Selected" checkbox in the PropertyGridEditor
(used by MultiCheckbox, MultiSelect, RadioButton, SingleSelect),
the `core/formElement/somePropertyChanged` event was incorrectly
fired for `properties.options` instead of `defaultValue`.

This happened due to three issues:

1. The `defaultValue` property had no registered publisher topic
   on the form element model, so `set('defaultValue', ...)` could
   never publish any event.

2. For single-selection elements, the `set()` call for
   `defaultValue` explicitly passed `disablePublishersOnSet: true`,
   suppressing event publishing even if a topic had been registered.

3. The `set()` call for `properties.options` was executed
   unconditionally on every change, even when only the selection
   state changed and the options data remained identical. This
   caused a misleading `somePropertyChanged` event with
   `propertyPath: properties.options` and identical old/new values.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 57

  1. Benni Mack commented on patch set 1 11/13/26, 09:34

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/inspector-component.js
  2. core-ci voted on patch set 1 V -1 11/13/26, 09:41 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114296

  3. Benni Mack uploaded patch set 2 V -1 11/13/26, 14:04

  4. core-ci voted on patch set 2 V +1 11/13/26, 14:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114329

  5. Benni Mack marked it ready for review 11/13/26, 14:18

  6. Benni Mack voted on patch set 2 CR +2 V +2 11/13/26, 14:18

  7. Benni Mack merged patch set 3 11/13/26, 14:18