Review 14.3 Merged

97604[BUGFIX] Stop delivering disabled webhooks from the runtime cache

Georg Ringer CR +2 V +2 Normal +133 −4 updated 11/13/26, 14:23

Commit message

The webhook message handler switched the shared WebhookRepository to
default restrictions and read the result from the runtime cache, whose
key ignored that switch. So whichever caller ran first decided whether
disabled webhooks were delivered, the switch leaked into later queries,
and a messenger:consume worker kept the webhook list of its first
message until it was restarted.

The handler now uses findActiveByType(), which always applies the
default restrictions and bypasses the runtime cache, and findAll()
caches restricted and unrestricted results separately.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 4

Review log 46

  1. Georg Ringer commented on patch set 1 11/13/26, 10:10

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V -1 11/13/26, 10:21 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114301

  3. Georg Ringer uploaded patch set 2 V -1 11/13/26, 11:50

  4. core-ci voted on patch set 2 V +1 11/13/26, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114313

  5. Benni Mack voted on patch set 2 CR +2 V +2 11/13/26, 14:23

  6. Benni Mack merged patch set 3 11/13/26, 14:23