97610[BUGFIX] Apply HTMLparser_db tag options inside lists and tables
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 2
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/10/97610/2 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/10/97610/2 && git cherry-pick FETCH_HEAD
Review
-
Code review CR +1 Needs a vote
- Simon Schaufelberger +1
-
Verified V +1 Needs a vote
- Simon Schaufelberger +1
- core-ci +1 CI
Merge conflicts 1
Issues 1
Files 2
Review log 57
-
Benni Mack uploaded patch set 1 11/13/26, 11:57
-
core-ci voted on patch set 1 V +1 11/13/26, 12:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114314
-
Oli Bartsch commented on patch set 1 11/13/26, 16:21
RteHtmlParser.php:403default now this skips `<br/>` to `<br />` normalisation, so `<td>x<br/>y</td>` would stored as `<br/ />`. Can we move the normalisation into `cleanHtmlForPersistence()` so both paths share it?RteHtmlParser.php:404The content of lists, tables, headings etc. now runs through the cleaner with `keepNonMatchedTags`, so markup not in `allowTags` is escaped or removed on re-save. That rewrites stored content, which we IMO shouldn't do in a bugfix. -
Benni Mack uploaded patch set 2
V +111/13/26, 20:33 -
Benni Mack commented on patch set 1 11/13/26, 20:34
RteHtmlParser.php:54ReplyDone. The default tag list is no longer changed. Inside blocks that aren't processed recursively, only the per-tag `HTMLparser_db.tags` options are applied now, and all other tags are kept as they are. So `<td><h3>…</h3>` stays intact, and the `span` expectation is back to the original.RteHtmlParser.php:403ReplyDone. It's now `normalizeSelfClosingTags()`, used by both paths, with a test for `<td>x<br/>y</td>`.RteHtmlParser.php:404ReplyDone. allowTags, denyTags, keepNonMatchedTags and htmlSpecialChars don't touch the content of these blocks any more. Only tag options the integrator configured explicitly (e.g. fixAttrib) are applied, which is what #102053 asks for. -
core-ci voted on patch set 2 V +1 11/13/26, 22:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114392
-
Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/13/26, 22:41
RteHtmlParser.php:54